-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Prepare Project for First Release #2
Conversation
…our_clf_io.RangeStyle` enumerations to `colour_clf_io.values` module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the upgrade and greatly expanded documentation!
self.assertEqual(len(clf_data.process_nodes), 3) | ||
|
||
assert clf_data is not None | ||
assert clf_data.description == ["Conversion from linear ACES2065-1 to ACEScct"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: what is the benefit of the bare assert over the assertEqual
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None beyond removing the unittest
module usage like we did for colour
et al. a few years ago.
Yes, I will add that once this PR is merged.
We might be able to refactor that to only extract the element first and then the text further up the call stack.
Yes! Will do that also when this PR is merged. |
Co-authored-by: Michael Mauderer <[email protected]>
Summary
This PR prepares the project for a first release:
colour_clf_io.ExponentStyle
,colour_clf_io.LogStyle
andcolour_clf_io.RangeStyle
enumerations were moved to thecolour_clf_io.values
module.A few notes collected whilst doing this:
colour_clf_io.SOPNode.slope
but we do not set any.colour_clf_io.parsing.child_elements
returningstr
is a major pain for type checking, we should look at a way of making sure that contextually, it only returnslxml.etree._Element | None
. I peppered the code with Pyright pragmas for now.colour_clf_io.ProcessNode.description
be alist[str]
likecolour_clf_io.ProcessList.description
?Preflight
Code Style and Quality
Documentation